Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation #47

Open
lastmjs opened this issue Mar 20, 2018 · 6 comments
Open

Update documentation #47

lastmjs opened this issue Mar 20, 2018 · 6 comments

Comments

@lastmjs
Copy link
Owner

lastmjs commented Mar 20, 2018

Especially mention the use of bare specifiers

@lastmjs
Copy link
Owner Author

lastmjs commented Mar 20, 2018

Once Polymer 3 is out and the world is switching to ES Modules, switch this entire repo to ES Modules, and rewrite the documentation with those examples. Also...maybe get rid of the Polymer examples and use lit-html directly

@lastmjs
Copy link
Owner Author

lastmjs commented Mar 29, 2018

I've already switched to ES Modules, I've mentioned bare specifiers, and so now I just need to use lit-html for the examples

@ernsheong
Copy link

ernsheong commented Apr 6, 2018

Have you tried using lit-html with this element? Using lit-extended, I seem unable to set the root-reducer to the value of a function, i.e. no initialization happens.

@lastmjs
Copy link
Owner Author

lastmjs commented Apr 6, 2018

I haven't yet. What version of redux-store-element are you using? The latest version uses bare specifiers, so you'll need to use polyserve or Zwitterion or another server that rewrites. Besides that, I'll see if I can check it out soon and debug what's going on

@lastmjs
Copy link
Owner Author

lastmjs commented Apr 7, 2018

@ernsheong Try using the rootReducer attribute instead of the root-reducer attribute to set the rootReducer property.

@ernsheong
Copy link

ernsheong commented Apr 7, 2018

@lastmjs thanks for taking time to repro. I'm on latest npm release 2.0.6. Using https://github.com/PolymerLabs/lit-element to encapsulate lit-html, and using webpack to build.

Setting rootReducer attribute directly works! Possibly related to how lit currently works: lit/lit-element#29 (it doesn't process hypenated attributes for now)

(Sorry for hijacking your documentation issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants