Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[question]: Convert CamelCaseKeys to lower_and_snake_case #8

Closed
erran opened this issue Mar 4, 2014 · 4 comments
Closed

[question]: Convert CamelCaseKeys to lower_and_snake_case #8

erran opened this issue Mar 4, 2014 · 4 comments

Comments

@erran
Copy link
Contributor

erran commented Mar 4, 2014

What everyone's opinion on this? User configurable, default option, etc.?
@lassebunk
Copy link
Owner

User configurable. :)

Dish.configure do |config|
  config.key_case = :camel_case # default is :keep
end

@erran
Copy link
Contributor Author

erran commented Mar 4, 2014

I like it. What should the behavior be when there is a bad type provided? Should we create error classes to raise (I rose a RuntimeError in one of the other PRs since there are no Dish::Errors yet.)

@lassebunk
Copy link
Owner

Nice.
I think it should raise ArgumentError right now.

@lassebunk
Copy link
Owner

Should we begin working on this? :)

@erran erran closed this as completed Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lassebunk @erran