Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create better footer #276

Open
josephwegner opened this issue Feb 28, 2014 · 3 comments
Open

Create better footer #276

josephwegner opened this issue Feb 28, 2014 · 3 comments

Comments

@josephwegner
Copy link
Collaborator

The current footer is starting to get a little busy (logs and releases are pending, but they will be there soon).

We should redesign the footer so that it looks better with more items in it.

@ESWAT
Copy link

ESWAT commented Mar 31, 2014

I can take a stab at this for earn my immigration papers :)

Also I noticed the footer does not appear below the 767px threshold. It the footer something we still want to retain at these low resolutions? (without occluding the current navigation that’s there already).

@josephwegner
Copy link
Collaborator Author

Hey @ESWAT,

I'm the guy who did the mobile redesign, and made the decision to remove the footer below 767px.

My general thought is that, if a user is unlikely to want to view a page on mobile, then don't show a link to it. There isn't enough screen real estate on mobile to waste on links that aren't useful in a mobile context. Currently, I don't think any of the links in the footer are useful on mobile (perhaps Github, but only maybe).

That said, the general vibe around Pullup is that if you think it's a good idea, do it. If other people disagree, or the data says differently, someone will put in a PR that reverts/fixes/enhances the decision you made. If you want the footer on mobile, put it in there. My voice doesn't carry any more weight than yours, so try whatever you want.

I look forward to seeing what you can put together for the footer!

@rickhanlonii
Copy link
Collaborator

Hey @josephwegner, do you still think this is a need? What sort of things are we going to add to the footer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants