Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Salvus' license message to stdout breaks VSCode test discovery #14

Open
larsgeb opened this issue May 22, 2020 · 0 comments
Open

Salvus' license message to stdout breaks VSCode test discovery #14

larsgeb opened this issue May 22, 2020 · 0 comments
Assignees
@larsgeb
Labels
bug Something isn't working
Milestone
1.2 - Long term f...

Comments

@larsgeb
Copy link
Owner

larsgeb commented May 22, 2020

When Salvus is imported during the import of hmc_tomography, a message is displayed showing the status of the license, e.g. here:
https://github.com/larsgeb/hmc-tomography/blob/21d2bb322b7da31457b3f0ae211972db3f211391/hmc_tomography/Distributions/__init__.py#L31
VSCode's way of discovering tests is to run Pytest's discover and parse its output. This gets mixed with the Salvus output and subsequently fails with a JSON error.

This is also a bad design choice of VSCode. Other people encounter these issues too: microsoft/vscode-python#11729.
@larsgeb larsgeb added the bug Something isn't working label May 22, 2020
@larsgeb larsgeb self-assigned this May 22, 2020
@larsgeb larsgeb added this to the 1.2 milestone Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@larsgeb larsgeb

Labels
bug Something isn't working
Projects
None yet
Milestone
1.2 - Long term features
Development

No branches or pull requests
1 participant
@larsgeb