Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landscape Ads Don't Appear with a Tab Bar Controller #15

Open
malcolmmurdock opened this issue Oct 12, 2012 · 9 comments
Open

Landscape Ads Don't Appear with a Tab Bar Controller #15

malcolmmurdock opened this issue Oct 12, 2012 · 9 comments
Labels

Comments

@malcolmmurdock
Copy link

Easy issue to reproduce:

  1. Create a new Tabbed Application in XCode

  2. Add LARSAdController and the necessary additional files (AdMob, frameworks, etc)

  3. Add LAC code to your view controller:

[[LARSAdController sharedManager] addAdContainerToView:self.view withParentViewController:self];
[[LARSAdController sharedManager] setShouldHandleOrientationChanges:YES];
[[LARSAdController sharedManager] setGoogleAdPublisherId:@"pubID"];
  1. Ads will display fine in Portrait Mode, but when you rotate to Landscape they fail to appear.
@larsacus
Copy link
Owner

Does it occur on a specific version of iOS, or is it multiple versions?

@malcolmmurdock
Copy link
Author

Seems to occur with both iOS 4.0 and 5.0. Haven't tested on any versions earlier or later than that (currently developing for iOS 4.0+). I'm running XCode 4.2 on Snow Leopard.

Thanks!

@larsacus
Copy link
Owner

If possible, please checkout the latest code from the AdapterAbstraction beta branch and see if this issue still persists. This is the new 3.0 development branch I've been working on for awhile that supports way more functionality than what's on master right now.

@jengo
Copy link

jengo commented Jan 2, 2013

I am having this issue with the AdapterAbstraction branch when the application only supports landscape mode. Installed the code as of today.

@larsacus
Copy link
Owner

larsacus commented Jan 2, 2013

Is the issue in the AdapterAbstraction branch still specifically with a view controller in a tab view controller, or is it just in landscape in general?

@jengo
Copy link

jengo commented Jan 2, 2013

It is with UITableViewController in the AdapterAbstraction branch while in landscape only mode.

@larsacus
Copy link
Owner

larsacus commented Jan 2, 2013

If you could open up a new issue with some sample code, it would be of great help.

@Fred10932
Copy link

I had the same issue (ads out of bounds in landscape) and adding the container view to the navigation controller instead of the view controller solved it:
[[LARSAdController sharedManager] addAdContainerToViewInViewController:self.navigationController].

Try [[LARSAdController sharedManager] addAdContainerToViewInViewController:self.tabBarController]?

@jengo
Copy link

jengo commented Apr 15, 2013

[[LARSAdController sharedManager] addAdContainerToViewInViewController:self.navigationController]

This worked for me when working inside a UITableViewController.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants