Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out how to write tests for this package #3

Open
mabasic opened this issue Jul 7, 2018 · 2 comments
Open

Figure out how to write tests for this package #3

mabasic opened this issue Jul 7, 2018 · 2 comments
Assignees
Labels
testing Issues related to testing

Comments

@mabasic
Copy link
Member

mabasic commented Jul 7, 2018

Need to test:

  • service provider
  • middleware
  • helper methods
@mabasic mabasic self-assigned this Jul 7, 2018
@mabasic mabasic added the testing Issues related to testing label Jul 7, 2018
@Lelectrolux
Copy link

Lelectrolux commented Jul 12, 2018

Hey, I'm the dude on reddit that gave you feedback (Lelectrolux). As I said I'm interested in that package, but I'd like to know if I'm welcomed to, or if you want to work alone on it (I'm fine with that too, your call).

If I can help, just give me a run down of the current pain points.

I'll try your email in a few days if I get no answers.


@mabasic
Copy link
Member Author

mabasic commented Jul 14, 2018

Hi @Lelectrolux, thanks for the feedback!

I would really like to get your help with the package. I have seen your PR, but I will continue the talk on the PR there.

Send me an email so we can start the conversation about contributing.

P.S. I have looked :)

@laravelista laravelista deleted a comment from Lelectrolux Jul 18, 2018
@laravelista laravelista deleted a comment from Lelectrolux Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Issues related to testing
Projects
None yet
Development

No branches or pull requests

2 participants