Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negotiating the language from the browser #12

Open
f-liva opened this issue Jun 27, 2019 · 8 comments
Open

Negotiating the language from the browser #12

f-liva opened this issue Jun 27, 2019 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@f-liva
Copy link

f-liva commented Jun 27, 2019

With mcamara/laravel-localization you can get the default language trough the browser when the URL does not explicitly state it.

How can I do that with Loki?

@mabasic
Copy link
Member

mabasic commented Jun 30, 2019

Currently Loki does not support that feature. I'm planning on creating a new version in which I will maybe include this.

Do you want me to ping you if I implement it?

@mabasic mabasic self-assigned this Jun 30, 2019
@mabasic mabasic added the enhancement New feature or request label Jun 30, 2019
@mabasic mabasic added this to the Next Big Release milestone Jun 30, 2019
@f-liva
Copy link
Author

f-liva commented Jul 1, 2019

Yes thank you!

@meduzen
Copy link

meduzen commented Jul 10, 2019

I subscribed to this issue, so the ping will be automatic.

@f-liva
Copy link
Author

f-liva commented Sep 3, 2019

any news here?

@mabasic
Copy link
Member

mabasic commented Sep 3, 2019

Not yet. I was trying to create a new version of loki which would tightly integrate with Laravel routing, but I failed. I'll give it another go, once I recover from the fail xD

@f-liva
Copy link
Author

f-liva commented Oct 19, 2019

I think we can use a middleware to negotiate the language... could be?

@mabasic
Copy link
Member

mabasic commented Oct 21, 2019

Yes, I'll try doing that.

@mabasic mabasic removed this from the Next Big Release milestone Oct 21, 2019
@f-liva
Copy link
Author

f-liva commented Nov 8, 2019

Great news! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants