Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable delete button when intent has a single text field #151

Open
4 tasks done
rodmaia opened this issue Feb 23, 2021 · 6 comments · May be fixed by #162
Open
4 tasks done

Disable delete button when intent has a single text field #151

rodmaia opened this issue Feb 23, 2021 · 6 comments · May be fixed by #162
Assignees
@Miguel-Alves
Labels
enhancement New feature or request frontend

Comments

@rodmaia
Copy link
Collaborator

rodmaia commented Feb 23, 2021 •
edited by Miguel-Alves
Loading

When an intent has a single text field, the delete button of that text field should be disabled as you cannot leave an intent with zero questions. The delete button should be reenabled once you add more text fields.

Tasks

  • Steps to complete this task
  • Steps to complete this task

Acceptance criteria

  • Delete button is disabled when there is a single text field
  • Delete button is enabled when there are two or more text fields
@rodmaia rodmaia added enhancement New feature or request frontend labels Feb 23, 2021
@Miguel-Alves Miguel-Alves mentioned this issue Feb 25, 2021
Open
4 tasks
@Miguel-Alves
Copy link
Collaborator

Reviewing this issue based on #153;

@Miguel-Alves Miguel-Alves self-assigned this Feb 25, 2021
@Miguel-Alves
Copy link
Collaborator

This issue was maintained following the procedures of #153;

Although it was maintained, it asks for a redundant work and validation, since there is already a validation that doesn't allow the user to delete the last or only question, even if the button is enabled.

@Miguel-Alves Miguel-Alves linked a pull request Mar 2, 2021 that will close this issue
Open
@Miguel-Alves
Copy link
Collaborator

Solved this issue as described in #162

@Miguel-Alves Miguel-Alves mentioned this issue Mar 2, 2021
Open
4 tasks
@rodmaia
Copy link
Collaborator Author

rodmaia commented Mar 2, 2021

Although it was maintained, it asks for a redundant work and validation, since there is already a validation that doesn't allow the user to delete the last or only question, even if the button is enabled.

It's not redundant because we are exposing the actual behavior in a way people can understand, following the usability principle of Visibility of the System 😉

@Miguel-Alves
Copy link
Collaborator

Got it! Thanks by the answer. It makes total sense.
The validation was added, and a PR to solve this issue is open.

@rodmaia
Copy link
Collaborator Author

rodmaia commented May 19, 2021

I tested it! Looks good on my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Miguel-Alves Miguel-Alves

Labels
enhancement New feature or request frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#151 disable delete button on single text field lappis-unb/BotFlow
2 participants
@rodmaia @Miguel-Alves