-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google AI Gemini: implement Spring Boot starter #2103
Google AI Gemini: implement Spring Boot starter #2103
Comments
/cc @glaforge (gemini) |
@langchain4j hey can i try working on it ? |
@Suhas-Koheda sure, thank you in advance! |
@langchain4j hey is there a streaming model for google gemini ai ? |
Okay jus found out that i was on the older version of langchain4j lol |
@langchain4j hey i have opened a pr regarding this :) |
@Suhas-Koheda thanks a lot, I will try to review it ASAP |
@langchain4j I’ve created a PR addressing the issue. It should resolve and close this issue. Please let me know if any changes are needed! |
@emredmrcan excuse me hey! |
@emredmrcan thank you, but @Suhas-Koheda is already working on this issue. What's the point to spend time on the duplicated effort? |
@Suhas-Koheda Yes, you are right. My bad! I thought you changed your direction after I just saw this message and read the title of your PR here (Change the safetySetting builder to support map of harmCategory and HarmBlockThreshold and toolConfig to support geminiMode and ListofFunctionNames). I needed to check further. I hope my PR request will be helpful for your implementation. I am sure it is missing some test cases and there are ways to improve it. Sorry again!
@langchain4j I added Chroma as a spring-boot-starter yesterday and I was thinking to add this quickly since I got familiar with. However, I missed the effort of @Suhas-Koheda. And you are right, there is no point to spend time on duplicated effort |
…armBlockThreshold and toolConfig to support geminiMode and ListofFunctionNames (#2217) ## Issue Related to PR of SpringBootStarterImplementation of GoogleAIGemini #2103 ## Change The Safety Settings and Tool Config for the streaming chat model were not properly configured The chat model and streaming chat model used different configurations changed the configurations of GoogleAIGeminiStreamingChatModel Changed the test configuration to check the workign of safetySettings since the GeminiModel returns the FINISHREASON as STOP so changed them to make the test cases passed in both chatModel and StreamingChatModel This pr if accepted makes the work related to spring boot starter implementation complete ## General checklist - [ x] There are no breaking changes - [ x] I have added unit and/or integration tests for my change - [ ] The tests cover both positive and negative cases - [ ] I have manually run all the unit and integration tests in the module I have added/changed, and they are all green - [ ] I have manually run all the unit and integration tests in the [core](https://github.com/langchain4j/langchain4j/tree/main/langchain4j-core) and [main](https://github.com/langchain4j/langchain4j/tree/main/langchain4j) modules, and they are all green <!-- Before adding documentation and example(s) (below), please wait until the PR is reviewed and approved. --> - [ ] I have added/updated the [documentation](https://github.com/langchain4j/langchain4j/tree/main/docs/docs) - [ ] I have added an example in the [examples repo](https://github.com/langchain4j/langchain4j-examples) (only for "big" features) - [ ] I have added/updated [Spring Boot starter(s)](https://github.com/langchain4j/langchain4j-spring) (if applicable)
Implement Spring Boot starter for
langchain4j-google-ai-gemini
in https://github.com/langchain4j/langchain4j-spring repoThe text was updated successfully, but these errors were encountered: