Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Make generic test source available #2336

Open
Martin7-1 opened this issue Dec 26, 2024 · 0 comments · May be fixed by langchain4j/langchain4j-spring#101 or #2337
Open

[FEATURE] Make generic test source available #2336

Martin7-1 opened this issue Dec 26, 2024 · 0 comments · May be fixed by langchain4j/langchain4j-spring#101 or #2337
Labels
enhancement New feature or request

Comments

@Martin7-1
Copy link
Contributor

Is your feature request related to a problem? Please describe.

EmbeddingStore's IT in community repo may extend EmbeddingStoreIT, EmbeddingStoreWithFilteringIT, etc. Main repo should expose test source for better debug functionality.

Describe the solution you'd like

Adding plugin in langchain4j-core and langchain4j-spring-boot-tests as following:

            <plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-source-plugin</artifactId>
                <version>3.3.1</version>
                <executions>
                    <execution>
                        <id>attach-sources</id>
                        <goals>
                            <goal>jar-no-fork</goal>
                            <!-- For getting test source -->
                            <goal>test-jar-no-fork</goal>
                        </goals>
                    </execution>
                </executions>
            </plugin>

Describe alternatives you've considered

No

Additional context

No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@Martin7-1