Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lando scanners scans .lndo.site urls which are not in config #67

Open
eldair opened this issue Sep 16, 2024 · 7 comments
Open

Lando scanners scans .lndo.site urls which are not in config #67

eldair opened this issue Sep 16, 2024 · 7 comments

Comments

@eldair
Copy link

eldair commented Sep 16, 2024

When using lando start scanner starts scanning .lndo.site url for my site but it is not enabled or written anywhere in the config file. This started happening week or two ago.

image
image

@AaronFeledy
Copy link
Member

The laravel recipe provides the lndo.site URLs by default. There was a bug that caused custom proxy config to overwrite these URLs rather than add to them. So, because you had a custom proxy config set, you were seeing the buggy behavior where the default URLs were not present. The bug was fixed in a recent release of the laravel plugin, so that's likely why you now see the default URLs when you hadn't before.

@eldair
Copy link
Author

eldair commented Sep 16, 2024

Interesting, so how I disable them? :D didn't see anything in the docs

@reynoldsalec
Copy link
Member

Ironically, there's not really a way to remove the default *.lndo.site URLs in the Landofile...you'd have to customize the Lando Laravel plugin to do it. So the "bug" in the Laravel plugin was actually a feature for you ;)

Is there a reason having those URLs is a problem?

@rtfm-47 rtfm-47 transferred this issue from lando/lando Sep 16, 2024
@eldair
Copy link
Author

eldair commented Sep 16, 2024

In that case I prefer the bugged version 😄 Jokes aside, I don't use them and the real issue is the scanner taking a lot of time scanning those urls which are not setup so they're returning error for every test

@reynoldsalec
Copy link
Member

@eldair in that case you could just disable the scanner: https://docs.lando.dev/core/v3/scanner.html#skipping

@eldair
Copy link
Author

eldair commented Sep 17, 2024

@reynoldsalec yeah, that is a good temp solution but won't that disable all scanners - even for my own urls?

@reynoldsalec
Copy link
Member

reynoldsalec commented Sep 17, 2024

Correct @eldair; I think the alternative would be to configure your app to use the *.lndo.site URLs. In my experience it's rare to have a local site need to have a specific URL, but realize that exceptions exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants