Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for running against a local docker image. #31

Open
codebymikey opened this issue Mar 1, 2023 · 0 comments · May be fixed by #32
Open

Add support for running against a local docker image. #31

codebymikey opened this issue Mar 1, 2023 · 0 comments · May be fixed by #32
Labels
bug Something isn't working

Comments

@codebymikey
Copy link

When trying to test lando against a locally built image, it makes an attempt to call docker-compose pull to pull, but crashes because the docker image doesn't exist in an upstream repo.

We should probably be building with docker-compose build --pull instead rather than have it as two separate commands (it's probably more performant too).


Example .lando.yml file:

# file: .lando.yml
name: docker-test
services:
  test:
    type: compose
    app_mount: delegated
    overrides:
      # This image only exists locally for now, so Lando should be able to use it just fine.
      image: docker-test/only-locally-available
      command: tail -f /dev/null
@codebymikey codebymikey added the bug Something isn't working label Mar 1, 2023
codebymikey added a commit to codebymikey/core that referenced this issue Mar 1, 2023
codebymikey added a commit to codebymikey/core that referenced this issue Mar 1, 2023
codebymikey added a commit to codebymikey/core that referenced this issue Mar 1, 2023
@pirog pirog linked a pull request Mar 2, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant