Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path is undefined error when using tilde expansion in plugin path #207

Open
AaronFeledy opened this issue Sep 11, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@AaronFeledy
Copy link
Member

😊:

plugins:
  'icanhaz/lolcats': '/home/moot/projects/lolcats'

🤮:

plugins:
  'icanhaz/lolcats': '~/projects/lolcats'

Did a quick pass with the debugger and it looks like during init of the plugin class, if the path has the tilde, the string ends up in the version field of the plugin class, instead of in the directory field. So, later down the line when directory is passed to some method's path parameter, Lando pukes backtrace.

@AaronFeledy AaronFeledy added the bug Something isn't working label Sep 11, 2024
@reynoldsalec
Copy link
Sponsor Member

I don't think we've really supported the ~ in most cases...I know I've had to custom-implement support for some of my plugins if I wanted it, so I'm assuming core doesn't as well. Not sure if there's a theory behind why it's not supported. Perhaps a good v4 goal?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants