Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version task fails if .lando.yml contains invalid config #192

Open
AaronFeledy opened this issue Aug 11, 2024 · 0 comments
Open

Version task fails if .lando.yml contains invalid config #192

AaronFeledy opened this issue Aug 11, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@AaronFeledy
Copy link
Member

AaronFeledy commented Aug 11, 2024

Since updated packages can be defined in .lando.yml, it makes sense that lando loads it to get versions. However, in situations such as those created by setup-lando in GHA, where a slim version of Lando is installed but service plugins are not yet downloaded, Lando throws errors on lando version about invalid service types in .lando.yml. This is causing most of the official Lando plugin's tests to fail because setup-lando validates the version before running lando setup.

Lando should probably have special error handling around tasks like version so that it will always succeed if obtaining the version is at all possible, even if other error states are present.

@AaronFeledy AaronFeledy added the bug Something isn't working label Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant