Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts/sql-import.sh unintentionally swallows exit code when a database import fails. #182

Open
codebymikey opened this issue Jul 10, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@codebymikey
Copy link

eval "$CMD" && lando_green "Import complete!" || lando_red "Import failed."

has an OR operator which calls lando_red "Import failed." and unintentionally swallows the original exit code failure.

This is made more apparent when importing a database dump affected by the mariadb sandbox breaking change - https://mariadb.org/mariadb-dump-file-compatibility-change/

@codebymikey codebymikey added the bug Something isn't working label Jul 10, 2024
@strzyzewski
Copy link

@codebymikey I think I ran across the same problem and accidentally created a duplicate of your issue: #217

We ran into this bug when we tried to import a dump which indeed was affected by the sandbox mode command into an older MariaDB version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants