Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MicroBitSerial::read(ASYNC) skips incoming bytes #441

Open
martinwork opened this issue May 26, 2019 · 0 comments · May be fixed by #442
Open

MicroBitSerial::read(ASYNC) skips incoming bytes #441

martinwork opened this issue May 26, 2019 · 0 comments · May be fixed by #442

Comments

@martinwork
Copy link
Contributor

https://github.com/lancaster-university/microbit-dal/blob/master/source/drivers/MicroBitSerial.cpp#L649

while((temp = getChar(mode)) != MICROBIT_NO_DATA && bufferIndex < bufferLen)

The order of the tests needs reversing. Similar to #201, which has been fixed.

I'll make a PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop MicroBitSerial::read(ASYNC) dropping bytes martinwork/microbit-dal
1 participant
@martinwork