-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable to pass storage region outside of create-s3
#768
Comments
I am not sure what do you mean here. Do we want to force passing the region on storage init? I think we need to make sure that the region is resolved even without access rights instead of forcing manual passing. https://github.com/fsspec/s3fs/blob/a28863f084a91ee78d9cd65bd6767b2f44e81b33/s3fs/utils.py#L40 |
I mean that we get a "HeadBucket operation: Forbidden" error because it's calling the below before the storage row is in the hub and access-aws can be called:
If we can get region without calling head_bucket: great! |
We still call the bucket and but we check the error header in the response and it should contain the region (see the code in |
That'd be a very elegant solution! Anytime this or early next week is fine! We worked around this issue where needed it so far and it's nothing that a user will face. |
We also need to be able to pass a storage region outside the
storage
param because otherwise duringinit_storage_hub
we'll try to infer it while not yet having access:lamindb-setup/lamindb_setup/core/_hub_core.py
Line 158 in 0501bb3
I'll make a PR that adds this ability.
The text was updated successfully, but these errors were encountered: