Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor comment update #12

Closed
weierophinney opened this issue Dec 31, 2019 · 2 comments
Closed

Minor comment update #12

weierophinney opened this issue Dec 31, 2019 · 2 comments

Comments

@weierophinney
Copy link
Member

The statement in injectEventManager's comments that a shared event manager is injected into an existing event manager is incorrect - the code replaces the existing event manager with a new one. That's what I updated.

I may have added too much 'how it works' detail, but I puzzled over this a bit so I thought the explanation might help future readers.


Originally posted by @bitwombat at zendframework/zend-mvc#285

@weierophinney
Copy link
Member Author

Also, I wonder about the pre-existing comment that "the conditional will always pass". I think that's true. Then does it need to be a conditional?


Originally posted by @bitwombat at zendframework/zend-mvc#285 (comment)

@alexmerlin
Copy link
Member

Closing issue due to being inactive for more than 1 year.

@alexmerlin alexmerlin closed this as not planned Won't fix, can't repro, duplicate, stale Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants