Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seek help for node 6.9.3 custom runtime - Doesn't implement context.succeed for node 6.9.3 - TypeError: context.succeed is not a function #15

Open
Vadorequest opened this issue Apr 14, 2019 · 0 comments

Comments

@Vadorequest
Copy link

I'm sorry to bother you, but since your have some experience with AWS Lambda custom runtimes I wonder if you could guide me.

I opened an issue a few days ago regarding implementing support for the soon-to-be-deprecated node6.10.3 official AWS Lambda runtime.

Since then I played around with custom runtimes quite a bit, and also tried to migrate my app, but I'm encountering errors even when using a custom runtime matching node6.10.3, because your lambda implementation doesn't exactly match the real AWS Lambda implementation. (which is normal, considering you ported the 10.x version and the official implementation isn't the same between 6 and 10).

But I'm struggling with the implementation itself and could use some help or guidance regarding the steps to take.

I released a first version of my custom runtime using your implementation, I'm now trying to change that implementation to match the AWS one, for node 6.10.3. I opened a PR Vadorequest#1 and I found some (of yours) gist regarding how it's implemented by AWS. But it's incomplete and seems to rely on closed sources.

I'm wondering if SSH-ing into a live 6.10 lambda and retrieving the content would be the right approach in order to copy the files AWS uses.


For instance, my current implementation changes the behaviour of the aws-serverless-express plugin, which relies on a context.succeed method (callback way), which is implemented as a Promise in node 10 and therefore doesn't have a succeed property.

CodeGenieApp/serverless-express#231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant