Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Add Components Folder #409

Open
ayezioro opened this issue Aug 8, 2017 · 4 comments
Open

Suggestion: Add Components Folder #409

ayezioro opened this issue Aug 8, 2017 · 4 comments

Comments

@ayezioro
Copy link
Contributor

ayezioro commented Aug 8, 2017

Hi,
There are already a few components (image viewer, item selector, FalseStartToggle) that need to be located at the components folder. Users usually, without knowing put all components together in the Users folder.
My suggestion is to add this folder in the github and maybe in the installation.
In addition or alternatively, in the instructions file to specify the files that need to be located in the components folder.
Thanks,
-A.

@MahmoudAbdelRahman
Copy link

Hi.
I usually drop them all into grasshopper canvas and each conponent goes automatically to its location. Is this a good practice ?

@ayezioro
Copy link
Contributor Author

ayezioro commented Aug 8, 2017

@MahmoudAbdelRahman,
Yes. Probably this is one way ... that for my own personal preferences i don't like/use.
For ghuser files if i drop on canvas, and i don't uninstall before, i get multiple copies on the tabs.
Gha files are fine using the drop way.
Usually i select from the zip file the contents and drop on the user folder.
-A.

@chriswmackey
Copy link
Member

@ayezioro and @MahmoudAbdelRahman ,
I'd like to hear @mostaphaRoudsari 's thoughts on this before implementing anything as he set up the original structure of putting everything in the userObjects folder.
This also means that we will have to revise all of our install instructions that currently say that you should just drag/drop all components onto the canvas but this can be done if it would make things easier from your perspective.

@mostaphaRoudsari
Copy link
Member

mostaphaRoudsari commented Sep 7, 2017

Thank you @ayezioro for the suggestion. It's a good idea and makes everything cleaner.
This is the list of tasks that we need to address if we are going to make this change:

  • installation process
  • uninstall script
  • update ladybug component
  • update honeybee component - I have been thinking for some time to merge these two components into 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants