test: retry failing tests and enable slack notification (#164)

Signed-off-by: Timothy MacDonald <[email protected]>

Author: Timothy MacDonald

.github/workflows/python-test.yml

@@ -55,14 +55,14 @@ jobs:
           LW_API_KEY: ${{ secrets.LW_API_KEY }}
           LW_API_SECRET: ${{ secrets.LW_API_SECRET }}
           LW_BASE_DOMAIN: ${{ secrets.LW_BASE_DOMAIN }}
-#      - name: Report Status
-#        if: always()
-#        uses: ravsamhq/notify-slack-action@v2
-#        with:
-#          status: ${{ job.status }}
-#          notify_when: "failure"
-#          notification_title: "{workflow} has {status_message}"
-#          message_format: "{emoji} *{workflow}* {status_message} in <{repo_url}|{repo}>"
-#          footer: "Linked Repo <{repo_url}|{repo}> | <${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}|View Workflow>"
-#        env:
-#          SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
+      - name: Report Status
+        if: always()
+        uses: ravsamhq/notify-slack-action@v2
+        with:
+          status: ${{ job.status }}
+          notify_when: "failure"
+          notification_title: "{workflow} has {status_message}"
+          message_format: "{emoji} *{workflow}* {status_message} in <{repo_url}|{repo}>"
+          footer: "Linked Repo <{repo_url}|{repo}> | <${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}|View Workflow>"
+        env:
+          SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}

tests/api/v2/test_agent_access_tokens.py

@@ -33,6 +33,7 @@ def test_api_create(self):
         Agent Access Tokens shouldn't be created with tests
         """
 
+    @pytest.mark.flaky(reruns=10)   # Because sometimes this attempts to get an object that has just been deleted
     @pytest.mark.order("first")
     def test_api_get_by_id(self, api_object):
         self._get_object_classifier_test(api_object, "id", self.OBJECT_ID_NAME)

tests/api/v2/test_alert_profiles.py

@@ -58,6 +58,7 @@ def test_api_search(self):
         """
         pass
 
+    @pytest.mark.flaky(reruns=10)   # Because sometimes this attempts to get an object that has just been deleted
     @pytest.mark.order("first")
     def test_api_get_by_id(self, api_object):
         self._get_object_classifier_test(api_object, "id", self.OBJECT_ID_NAME)

tests/api/v2/test_alert_rules.py

@@ -45,6 +45,7 @@ class TestAlertRules(CrudEndpoint):
     OBJECT_ID_NAME = "mcGuid"
     OBJECT_TYPE = AlertRulesAPI
 
+    @pytest.mark.flaky(reruns=10)   # Because sometimes this attempts to get an object that has just been deleted
     @pytest.mark.order("first")
     def test_api_get_by_guid(self, api_object):
         self._get_object_classifier_test(api_object, "guid", self.OBJECT_ID_NAME)
@@ -69,4 +70,4 @@ def test_api_search(self, api_object, request):
                 "returns": [
                     "filters"
                 ]
-            })
+            })

tests/api/v2/test_alerts.py

@@ -70,12 +70,14 @@ def test_comment(self, api_object):
         response = api_object.comment(guid, "Test Comment")
         assert "data" in response.keys()
 
+    @pytest.mark.flaky(reruns=10)   # Because sometimes this attempts to close an  alert that isn't allowed
     def test_close_fp(self, api_object, open_alerts_filter):
         guid = self._search_random_object(api_object, self.OBJECT_ID_NAME, open_alerts_filter)
         if guid:
             response = api_object.close(guid, 1)
             assert "data" in response.keys()
 
+    @pytest.mark.flaky(reruns=10)   # Because sometimes this attempts to close an  alert that isn't allowed
     def test_close_other(self, api_object, open_alerts_filter):
         guid = self._search_random_object(api_object, self.OBJECT_ID_NAME, open_alerts_filter)
         if guid:

tests/api/v2/test_container_registries.py

@@ -41,6 +41,7 @@ class TestContainerRegistries(CrudEndpoint):
     OBJECT_ID_NAME = "intgGuid"
     OBJECT_TYPE = ContainerRegistriesAPI
 
+    @pytest.mark.flaky(reruns=10)   # Because sometimes this attempts to get an object that has just been deleted
     @pytest.mark.order("first")
     def test_api_get_by_guid(self, api_object):
         self._get_object_classifier_test(api_object, "guid", self.OBJECT_ID_NAME)

tests/api/v2/test_data_export_rules.py

@@ -44,6 +44,7 @@ class TestDataExportRules(CrudEndpoint):
     OBJECT_ID_NAME = "mcGuid"
     OBJECT_TYPE = DataExportRulesAPI
 
+    @pytest.mark.flaky(reruns=10)   # Because sometimes this attempts to get an object that has just been deleted
     @pytest.mark.order("first")
     def test_api_get_by_guid(self, api_object):
-        self._get_object_classifier_test(api_object, "guid", self.OBJECT_ID_NAME)
+        self._get_object_classifier_test(api_object, "guid", self.OBJECT_ID_NAME)

tests/api/v2/test_policies.py

@@ -68,6 +68,7 @@ class TestPolicies(CrudEndpoint):
     OBJECT_ID_NAME = "policyId"
     OBJECT_TYPE = PoliciesAPI
 
+    @pytest.mark.flaky(reruns=10)   # Because sometimes this attempts to get an object that has just been deleted
     def test_api_get_by_id(self, api_object):
         self._get_object_classifier_test(api_object, "id", self.OBJECT_ID_NAME)
 

tests/api/v2/test_policy_exceptions.py

@@ -75,6 +75,7 @@ def test_api_create(self, api_object, policy_id, api_object_create_body, request
 
         request.config.cache.set(self.OBJECT_ID_NAME, response["data"][self.OBJECT_ID_NAME])
 
+    @pytest.mark.flaky(reruns=10)   # Because sometimes this attempts to get an object that has just been deleted
     @pytest.mark.order("first")
     def test_api_get_by_guid(self, api_object, policy_id, policy_exception_id):
         response = api_object.get(policy_exception_id, policy_id)

tests/api/v2/test_queries.py

@@ -54,6 +54,7 @@ class TestQueries(CrudEndpoint):
     OBJECT_ID_NAME = "queryId"
     OBJECT_TYPE = QueriesAPI
 
+    @pytest.mark.flaky(reruns=10)   # Because sometimes this attempts to get an object that has just been deleted
     @pytest.mark.order("first")
     def test_api_get_by_id(self, api_object):
         self._get_object_classifier_test(api_object, "id", self.OBJECT_ID_NAME)