Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting of hosts could be prettier #168

Open
justindotpub opened this issue Aug 31, 2017 · 4 comments
Open

Formatting of hosts could be prettier #168

justindotpub opened this issue Aug 31, 2017 · 4 comments

Comments

@justindotpub
Copy link

Is there a reason why there's an extra space after the IP address in all bootleg output?

[a.b.c.d ]
@rjanja
Copy link
Contributor

rjanja commented Aug 31, 2017

The host name is padded with 10 spaces to the right. In your case it's an IP address but this could also be an alias from /etc/hosts or a fully-qualified domain name.

The original reason for this was an attempt to get host names to line up when having multiple servers, e.g.:

[host1  ] doing it
[host256] doing it

@justindotpub
Copy link
Author

Okay, so this just gets them to line up right if they aren't too long (i.e. no 15 character IP addresses or longer than 10 char hostnames). It just looks off, but it obviously doesn't need to be considered a bug. :)

@rjanja rjanja changed the title Extra space after IP address Formatting of hosts could be prettier Sep 1, 2017
@rjanja
Copy link
Contributor

rjanja commented Sep 1, 2017

Discussed this with @holetse earlier and we decided to keep this around as a future fix-it ticket. One possible solution he brought up: Bootleg could calculate maximum length of hostnames / IPs and decide on a padding format at start-up.

@brienw
Copy link
Contributor

brienw commented Oct 2, 2017

How are we feeling about just padding like so:

[host]    do it
[host123] do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants