Skip to content

Commit 20a5ce2

Browse files
committed
Add check for well known URL of WebFinger in the settings overview
If the WebFinger service is not set in Nextcloud configuration no check is performed. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
1 parent d143b43 commit 20a5ce2

File tree

2 files changed

+19
-2
lines changed

2 files changed

+19
-2
lines changed

settings/Application.php

+16
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,8 @@ public function register() {
121121

122122
Util::connectHook('OC_User', 'post_setPassword', $this, 'onChangePassword');
123123
Util::connectHook('OC_User', 'changeUser', $this, 'onChangeInfo');
124+
125+
Util::connectHook('\OCP\Config', 'js', $this, 'extendJsConfig');
124126
}
125127

126128
/**
@@ -152,4 +154,18 @@ public function onChangeInfo(array $parameters) {
152154
$hooks = $this->getContainer()->query(Hooks::class);
153155
$hooks->onChangeEmail($parameters['user'], $parameters['old_value']);
154156
}
157+
158+
/**
159+
* @param array $settings
160+
*/
161+
public function extendJsConfig(array $settings) {
162+
$appConfig = json_decode($settings['array']['oc_appconfig'], true);
163+
164+
$publicWebFinger = \OC::$server->getConfig()->getAppValue('core', 'public_webfinger', '');
165+
if (!empty($publicWebFinger)) {
166+
$appConfig['core']['public_webfinger'] = $publicWebFinger;
167+
}
168+
169+
$settings['array']['oc_appconfig'] = json_encode($appConfig);
170+
}
155171
}

settings/js/admin.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -248,13 +248,14 @@ $(document).ready(function(){
248248
// run setup checks then gather error messages
249249
$.when(
250250
OC.SetupChecks.checkWebDAV(),
251+
OC.SetupChecks.checkWellKnownUrl('/.well-known/webfinger', oc_defaults.docPlaceholderUrl, $('#postsetupchecks').data('check-wellknown') === true && !!oc_appconfig.core.public_webfinger, 200),
251252
OC.SetupChecks.checkWellKnownUrl('/.well-known/caldav', oc_defaults.docPlaceholderUrl, $('#postsetupchecks').data('check-wellknown') === true),
252253
OC.SetupChecks.checkWellKnownUrl('/.well-known/carddav', oc_defaults.docPlaceholderUrl, $('#postsetupchecks').data('check-wellknown') === true),
253254
OC.SetupChecks.checkSetup(),
254255
OC.SetupChecks.checkGeneric(),
255256
OC.SetupChecks.checkDataProtected()
256-
).then(function(check1, check2, check3, check4, check5, check6) {
257-
var messages = [].concat(check1, check2, check3, check4, check5, check6);
257+
).then(function(check1, check2, check3, check4, check5, check6, check7) {
258+
var messages = [].concat(check1, check2, check3, check4, check5, check6, check7);
258259
var $el = $('#postsetupchecks');
259260
$('#security-warning-state-loading').addClass('hidden');
260261

0 commit comments

Comments
 (0)