Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore warnings and notices when running validation #23

Open
demeyerthom opened this issue Oct 16, 2023 · 2 comments
Open

Ignore warnings and notices when running validation #23

demeyerthom opened this issue Oct 16, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@demeyerthom
Copy link
Member

demeyerthom commented Oct 16, 2023

We currently fail a validation when the validation process returns notices. We should make sure that a notice is not breaking for the validation, but instead only logged as output of the terraform apply.

Optionally we might want to add some additional configs for the apollostudio_sub_graph_validation data source to be more strict and fail on notice, so we can support both

image

image

@demeyerthom demeyerthom added bug Something isn't working triage Needs triage and removed triage Needs triage labels Oct 16, 2023
@demeyerthom demeyerthom self-assigned this Dec 15, 2023
@demeyerthom
Copy link
Member Author

@okkevandereijk Can you maybe clarify what is currently happening, and what is expected?

@okkevandereijk
Copy link
Member

@demeyerthom We likely would like to have a way to explicility skip errors in our schema checking without blocking pipelines/releases. If you can clarify the options that would be great

@demeyerthom demeyerthom removed their assignment Mar 29, 2024
@demeyerthom demeyerthom added enhancement New feature or request and removed bug Something isn't working labels Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants