New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use const arguments #11

Open

paulpach opened this issue Jun 15, 2017 · 0 comments

paulpach commented Jun 15, 2017

I found this code:

 int HttpParser::_parse_desc(char* recv_buf, Request& request) {

If I am reading the code correctly you never modify the contents of recv_buf, so it should be:

 int HttpParser::_parse_desc(const char* recv_buf, Request& request) {

I would also consider using std::string instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment