New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memory leak 2 #10

Open

paulpach opened this issue Jun 15, 2017 · 0 comments

paulpach commented Jun 15, 2017

I found this code:

int main() {
    
    sub_framework::Request* request = new sub_framework::Request();
    sub_framework::HttpParser* http_parser = new sub_framework::HttpParser();
    char *recv_buf = "";
    http_parser->_parse(recv_buf, *request);
    return 0;
}

Valgrind would flag that as a memory leak, consider allocating the request and parser in the stack instead:

int main() {
    
    sub_framework::Request request;
    sub_framework::HttpParser http_parser;
    char *recv_buf = "";
    http_parser->_parse(recv_buf, *request);
    return 0;
}

or use smart pointers instead of raw pointers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment