Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix workflow not sleeping after output results #1472

Merged
merged 1 commit into from
Sep 24, 2024
Merged

chore: Fix workflow not sleeping after output results #1472

merged 1 commit into from
Sep 24, 2024

Conversation

jeffreylimnardy
Copy link
Contributor

Description

Changes proposed in this pull request (what was done and why):

  • Workflow script was not sleeping after outputting results, which continuously polled the GitHub API without any intervals and caused API rate limite errors

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@jeffreylimnardy jeffreylimnardy added area/ci Test automation kind/chore Categorizes issue or PR as related to a chore. labels Sep 24, 2024
@jeffreylimnardy jeffreylimnardy added this to the 1.25.0 milestone Sep 24, 2024
@jeffreylimnardy jeffreylimnardy self-assigned this Sep 24, 2024
@jeffreylimnardy jeffreylimnardy requested a review from a team as a code owner September 24, 2024 09:18
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 24, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 24, 2024
@TeodorSAP TeodorSAP modified the milestones: 1.25.0, 1.24.0 Sep 24, 2024
@kyma-bot kyma-bot merged commit 9507acd into kyma-project:main Sep 24, 2024
69 of 76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeodorSAP TeodorSAP TeodorSAP approved these changes

Assignees

@jeffreylimnardy jeffreylimnardy

@TeodorSAP TeodorSAP

Labels
area/ci Test automation cla: yes Indicates the PR's author has signed the CLA. kind/chore Categorizes issue or PR as related to a chore. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffreylimnardy @TeodorSAP @kyma-bot