Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make v1alpha1 LogPipeline input disableable #1469

Merged

Conversation

skhalash
Copy link
Collaborator

@skhalash skhalash commented Sep 23, 2024

Description

Changes proposed in this pull request (what was done and why):

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@skhalash skhalash added kind/chore Categorizes issue or PR as related to a chore. area/logs LogPipeline labels Sep 23, 2024
@skhalash skhalash requested a review from a team as a code owner September 23, 2024 20:13
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 23, 2024
@skhalash skhalash added kind/feature Categorizes issue or PR as related to a new feature. and removed cla: yes Indicates the PR's author has signed the CLA. labels Sep 23, 2024
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 23, 2024
@skhalash skhalash removed the kind/chore Categorizes issue or PR as related to a chore. label Sep 23, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 23, 2024
@skhalash
Copy link
Collaborator Author

/hold

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2024
@skhalash skhalash added this to the 1.25.0 milestone Sep 24, 2024
@skhalash skhalash requested a review from a team as a code owner September 24, 2024 14:13
NHingerl
NHingerl previously approved these changes Sep 24, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 24, 2024
@shorim
Copy link
Contributor

shorim commented Sep 24, 2024

Should we add an e2e test to check that no logs are collected when the application input is disabled?

@skhalash
Copy link
Collaborator Author

Not sure, I thought a unit test would be enough. I could add it if you think it's necessary.

@kyma-bot kyma-bot removed the lgtm Looks good to me! label Sep 24, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 24, 2024
@skhalash
Copy link
Collaborator Author

skhalash commented Sep 24, 2024

@shorim Added an E2E test

@skhalash
Copy link
Collaborator Author

/unhold

@kyma-bot kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 25, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 25, 2024
@kyma-bot kyma-bot merged commit f1fac4c into kyma-project:main Sep 25, 2024
56 checks passed
@skhalash skhalash deleted the logpipeline-v1alpha1-input-disableable branch September 25, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logs LogPipeline cla: yes Indicates the PR's author has signed the CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants