generated from kyma-project/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make v1alpha1 LogPipeline input disableable #1469
Merged
kyma-bot
merged 11 commits into
kyma-project:main
from
skhalash:logpipeline-v1alpha1-input-disableable
Sep 25, 2024
Merged
feat: Make v1alpha1 LogPipeline input disableable #1469
kyma-bot
merged 11 commits into
kyma-project:main
from
skhalash:logpipeline-v1alpha1-input-disableable
Sep 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skhalash
added
kind/chore
Categorizes issue or PR as related to a chore.
area/logs
LogPipeline
labels
Sep 23, 2024
skhalash
added
kind/feature
Categorizes issue or PR as related to a new feature.
and removed
cla: yes
Indicates the PR's author has signed the CLA.
labels
Sep 23, 2024
kyma-bot
added
the
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
label
Sep 23, 2024
/hold |
kyma-bot
added
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Sep 24, 2024
… logpipeline-v1alpha1-input-disableable
… logpipeline-v1alpha1-input-disableable
NHingerl
previously approved these changes
Sep 24, 2024
shorim
reviewed
Sep 24, 2024
Should we add an e2e test to check that no logs are collected when the application input is disabled? |
Not sure, I thought a unit test would be enough. I could add it if you think it's necessary. |
kyma-bot
added
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
and removed
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Sep 24, 2024
@shorim Added an E2E test |
/unhold |
kyma-bot
removed
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Sep 25, 2024
nataliasitko
approved these changes
Sep 25, 2024
shorim
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/logs
LogPipeline
cla: yes
Indicates the PR's author has signed the CLA.
kind/feature
Categorizes issue or PR as related to a new feature.
lgtm
Looks good to me!
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request (what was done and why):
Changes refer to particular issues, PRs or documents:
Traceability
Related Issues
section.