Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Remove LogPipeline loki output #1437

Merged
merged 2 commits into from
Sep 12, 2024
Merged

feat: Remove LogPipeline loki output #1437

merged 2 commits into from
Sep 12, 2024

Conversation

hisarbalik
Copy link
Contributor

@hisarbalik hisarbalik commented Sep 11, 2024 •
edited
Loading

Description

Changes proposed in this pull request (what was done and why):

  • Remove output type grafana-loki from LogPipeline
  • Remove LogPipeline grafana-loki output unit tests
  • Remove LogPipeline grafana-loki output e2e test
  • Remove LogPipeline grafana-loki output from docs

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@hisarbalik hisarbalik requested review from a team as code owners September 11, 2024 19:07
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 11, 2024
@hisarbalik hisarbalik added area/tests Writing/adding/Refactoring tests or checks area/documentation Documentation changes do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/logs LogPipeline kind/docs Categorizes issue or PR as related to a documentation change kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Sep 11, 2024
@hisarbalik hisarbalik added this to the 1.24.0 milestone Sep 11, 2024
@hisarbalik hisarbalik linked an issue Sep 11, 2024 that may be closed by this pull request
Remove loki output #873
Closed
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 11, 2024
@hisarbalik hisarbalik added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/docs Categorizes issue or PR as related to a documentation change labels Sep 11, 2024
@kyma-bot kyma-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 11, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 12, 2024
@hisarbalik hisarbalik removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2024
@kyma-bot kyma-bot merged commit c9d950c into kyma-project:main Sep 12, 2024
49 checks passed
@hisarbalik hisarbalik deleted the remove-logpipeline-loki-output branch September 12, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skhalash skhalash skhalash approved these changes

@NHingerl NHingerl NHingerl approved these changes

Assignees

@skhalash skhalash

@NHingerl NHingerl

Labels
area/documentation Documentation changes area/logs LogPipeline area/tests Writing/adding/Refactoring tests or checks cla: yes Indicates the PR's author has signed the CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

Remove loki output
4 participants
@hisarbalik @skhalash @NHingerl @kyma-bot