Skip to content

Commit

Permalink
Add round-trip tests
Browse files Browse the repository at this point in the history
  • Loading branch information
skhalash committed Sep 22, 2024
1 parent 402c74c commit 9887371
Showing 1 changed file with 14 additions and 1 deletion.
15 changes: 14 additions & 1 deletion apis/telemetry/v1alpha1/logpipeline_conversion_test.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package v1alpha1

import (
"reflect"
"testing"

"github.com/stretchr/testify/require"
Expand Down Expand Up @@ -92,9 +93,15 @@ func TestConvertTo(t *testing.T) {
dst := &telemetryv1beta1.LogPipeline{}

err := src.ConvertTo(dst)
require.NoError(t, err, "expected no error during ConvertTo")
require.NoError(t, err)

requireLogPipelinesEquivalent(t, src, dst)

srcAfterRoundTrip := &LogPipeline{}
err = srcAfterRoundTrip.ConvertFrom(dst)
require.NoError(t, err)

require.True(t, reflect.DeepEqual(src, srcAfterRoundTrip), "expected source and source after round-trip to be equal")
}

func TestConvertFrom(t *testing.T) {
Expand Down Expand Up @@ -182,6 +189,12 @@ func TestConvertFrom(t *testing.T) {
require.NoError(t, err, "expected no error during ConvertTo")

requireLogPipelinesEquivalent(t, dst, src)

srcAfterRoundTrip := &telemetryv1beta1.LogPipeline{}
err = dst.ConvertTo(srcAfterRoundTrip)
require.NoError(t, err, "expected no error during ConvertFrom (round-trip)")

require.True(t, reflect.DeepEqual(src, srcAfterRoundTrip), "expected source and source after round-trip to be equal")
}

func requireLogPipelinesEquivalent(t *testing.T, x *LogPipeline, y *telemetryv1beta1.LogPipeline) {
Expand Down

0 comments on commit 9887371

Please sign in to comment.