Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate all the pipelines out of Prow #1811

Closed
3 tasks done
janmedrek opened this issue Aug 28, 2024 · 3 comments
Closed
3 tasks done

Migrate all the pipelines out of Prow #1811

janmedrek opened this issue Aug 28, 2024 · 3 comments
Assignees
@ruanxin @amritanshusikdar
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@janmedrek
Copy link
Contributor

janmedrek commented Aug 28, 2024 •
edited by amritanshusikdar
Loading

Description

All the pipelines (including the build ones) should be migrated to the GH Actions feature.

The list of pipelines that are still in Prow is available here.

The release-template-operator-assets is a bit problematic since we cannot upload the files ourselves to the productive storage. We need to align with Neighbors on how to proceed and log a follow-up ticket.

Reasons

Prow will be sunset and we need to move to our own solution.

Acceptance Criteria

  • All the necessary pipelines migrated to GH Actions
  • Jellyfish team owns no pipelines in Prow (besides release-template-operator-assets)
  • Follow-up for migrating the release-template-operator-assets pipeline created
    • this pipeline should be revisited as a whole - do we still need it? should the module template be there?

Feature Testing

No response

Testing approach

No response

Attachments

Quickstart guide for Image Builder: https://github.com/kyma-project/test-infra/blob/main/cmd/image-builder/README.md#quickstart-guide
@janmedrek janmedrek added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 28, 2024
@janmedrek janmedrek mentioned this issue Aug 28, 2024
Closed
@amritanshusikdar amritanshusikdar self-assigned this Aug 29, 2024
@amritanshusikdar amritanshusikdar mentioned this issue Aug 29, 2024
Merged
@ruanxin ruanxin mentioned this issue Sep 2, 2024
Merged
@amritanshusikdar amritanshusikdar mentioned this issue Sep 2, 2024
Merged
kyma-bot pushed a commit to kyma-project/template-operator that referenced this issue Sep 2, 2024
@ruanxin
fix: Upload assets from github action (#245)
37464d8 
<!-- Thank you for your contribution. Before you submit the pull
request:
1. Follow contributing guidelines, templates, the recommended Git
workflow, and any related documentation.
2. Read and submit the required Contributor Licence Agreements
(https://github.com/kyma-project/community/blob/main/CONTRIBUTING.md#agreements-and-licenses).
3. Test your changes and attach their results to the pull request.
4. Update the relevant documentation.

If the pull request requires a decision, follow the [decision-making
process](https://github.com/kyma-project/community/blob/main/governance.md)
and replace the PR template with the [decision record
template](https://github.com/kyma-project/community/blob/main/.github/ISSUE_TEMPLATE/decision-record.md).
-->

**Description**

related kyma-project/lifecycle-manager#1811
**Related issue(s)**
<!-- If you refer to a particular issue, provide its number. For
example, `Resolves #123`, `Fixes #43`, or `See also #33`. -->
@amritanshusikdar
Copy link
Contributor

The plan with this issue is to go phase-wise and not do everything at once. For the first phase, we have:

  1. The GitHub Action workflow for image building has been added to template-operator.
  2. The respective Prow Job in test-infra has been removed.
  3. Assets uploading from GitHub Actions here.

amritanshusikdar added a commit to kyma-project/template-operator that referenced this issue Sep 2, 2024
@amritanshusikdar
feat: Add GitHub Action for template-operator Image Build (#243)
6c20d1c 
**Description**
This PR aims to make this `template-operator` repository use GitHub
Actions for building images, drop dependency on Prow Jobs for image
builds.

**Related Issues**
- Resolves a part of [this
issue](kyma-project/lifecycle-manager#1811)
- Implementation in support of [this
issue](kyma-project/lifecycle-manager#1811)
@amritanshusikdar amritanshusikdar mentioned this issue Sep 3, 2024
Merged
@ruanxin ruanxin mentioned this issue Sep 3, 2024
Merged
@amritanshusikdar amritanshusikdar mentioned this issue Sep 3, 2024
Merged
kyma-bot pushed a commit to kyma-project/template-operator that referenced this issue Sep 3, 2024
@amritanshusikdar
chore: Rename pull-build-template-operator to build-template-operator (…
f7e9569 
…#248)

**Description**

Changes proposed in this pull request:
- Renaming `pull-build-template-operator` to `build-template-operator`

**Related Issues**
In cooperation with
kyma-project/lifecycle-manager#1811
@amritanshusikdar
Copy link
Contributor

amritanshusikdar commented Sep 3, 2024 •
edited
Loading

As discussed in the daily, we renamed the newly introduced pipeline to template-operator from pull-build-template-operator to just build-template-operator, which can be seen here.

Moreover, main-template-op-build and release-template-operator-build have also been removed. See here.

kyma-bot pushed a commit to kyma-project/template-operator that referenced this issue Sep 3, 2024
@ruanxin
chore: Remove module version file (#247)
f7a3c4e 
<!-- Thank you for your contribution. Before you submit the pull
request:
1. Follow contributing guidelines, templates, the recommended Git
workflow, and any related documentation.
2. Read and submit the required Contributor Licence Agreements
(https://github.com/kyma-project/community/blob/main/CONTRIBUTING.md#agreements-and-licenses).
3. Test your changes and attach their results to the pull request.
4. Update the relevant documentation.

If the pull request requires a decision, follow the [decision-making
process](https://github.com/kyma-project/community/blob/main/governance.md)
and replace the PR template with the [decision record
template](https://github.com/kyma-project/community/blob/main/.github/ISSUE_TEMPLATE/decision-record.md).
-->

**Description**

Align template operator release with klm, remove the version validation
based on a fixed version file.

**Related issue(s)**
kyma-project/lifecycle-manager#1811
@ruanxin
Copy link
Contributor

ruanxin commented Sep 3, 2024 •
edited
Loading

regarding release-template-operator-assets

@ruanxin ruanxin mentioned this issue Sep 3, 2024
Merged
This was referenced Sep 4, 2024
Merged
Merged
This was referenced Sep 5, 2024
Merged
Merged
@amritanshusikdar amritanshusikdar self-assigned this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruanxin ruanxin

@amritanshusikdar amritanshusikdar

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ruanxin @janmedrek @amritanshusikdar