Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Module catalogue improvements] Implement new Module Catalog support #1591

Closed
6 tasks done
Tomasz-Smelcerz-SAP opened this issue May 31, 2024 · 0 comments · Fixed by #1748
Closed
6 tasks done

[Module catalogue improvements] Implement new Module Catalog support #1591

Tomasz-Smelcerz-SAP opened this issue May 31, 2024 · 0 comments · Fixed by #1748
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@Tomasz-Smelcerz-SAP
Copy link
Member

Tomasz-Smelcerz-SAP commented May 31, 2024

Description

Implement new logic to support use cases described here
The API changes are introduced by these two issues: #1590, #1589.

Note: At this moment it is not 100% clear which scenarios related to module management must be supported. Precisely, what happens if:

  • A Module foo is installed from a channel fast. After a long time, the Module Catalog changes and there is no more ModuleTemplate for foo in the fast channel What happens then?

Such scenarios must be either excluded (it will not happen because...) or implemented as part of this issue.

Reasons

We need it to support use cases described here

Acceptance Criteria

  • Resolve doubts related to Module Catalog changes (as described) - this requires a separate issue related to module sunset procedure. We do NOT implement it here.
  • The Lifecycle-Manager must support both the old ModuleTemplates and a new ones (with extended attributes) - we must provide a smooth migration path
  • Installing an explicit module version is supported (this is new)
  • Installing a module using a channel name is supported (this logic already exists)
  • Automatic upgrade of a module installed using a channel name is supported (this logic already exists)
  • No module downgrade is supported (based on semantic versioning)

Feature Testing

unit test, integration test, e2e test

Testing approach

Ensure in the e2e test that the old ModuleTemplate attributes (as of now) and the new ones (as implemented by this issue) are supported.

Attachments

No response

Related issue(s)

#1472, #1590

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants