Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KIM Integration - egress setting based on license #1029

Merged
merged 1 commit into from
Aug 19, 2024
Merged

KIM Integration - egress setting based on license #1029

merged 1 commit into from
Aug 19, 2024

Conversation

jaroslaw-pieszka
Copy link
Contributor

@jaroslaw-pieszka jaroslaw-pieszka commented Aug 12, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Setting Networking.Filter.Egress according to LicenseType
  • auxiliary functions to handle parameters (defaults and user defined ones)

Related issue(s)

#905
#791

@jaroslaw-pieszka jaroslaw-pieszka self-assigned this Aug 12, 2024
@jaroslaw-pieszka jaroslaw-pieszka requested a review from a team as a code owner August 12, 2024 15:28
@jaroslaw-pieszka jaroslaw-pieszka added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Aug 12, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 12, 2024
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 12, 2024
@jaroslaw-pieszka jaroslaw-pieszka added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 12, 2024
@jaroslaw-pieszka jaroslaw-pieszka force-pushed the handling-defaults branch 4 times, most recently from 3f2a7f3 to 242e448 Compare August 14, 2024 06:15
@jaroslaw-pieszka jaroslaw-pieszka removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 14, 2024
@jaroslaw-pieszka jaroslaw-pieszka added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 14, 2024
@jaroslaw-pieszka jaroslaw-pieszka force-pushed the handling-defaults branch 2 times, most recently from 51c734a to ba37688 Compare August 16, 2024 10:17
@jaroslaw-pieszka jaroslaw-pieszka removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2024
@jaroslaw-pieszka
rebase
b9b2ab5 
rebase

all tests passing
@szwedm szwedm self-requested a review August 19, 2024 07:38
szwedm
szwedm approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@szwedm szwedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 19, 2024
@kyma-bot kyma-bot merged commit 983b4dc into kyma-project:main Aug 19, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szwedm szwedm szwedm approved these changes

@piotrmiskiewicz piotrmiskiewicz Awaiting requested review from piotrmiskiewicz

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

@szwedm szwedm

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaroslaw-pieszka @szwedm @kyma-bot