Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare KCP CLI enhancements #917

Open
piotrmiskiewicz opened this issue Jul 8, 2024 · 7 comments
Open

Prepare KCP CLI enhancements #917

piotrmiskiewicz opened this issue Jul 8, 2024 · 7 comments
Assignees

Comments

@piotrmiskiewicz
Copy link
Member

  1. Prepare a list of changes which improve the KCP CLI
  2. Organize a meeting with the team and later with SRE
  • getting betaEnabled per subaccount
  • getting usedForProduction per subaccount
@piotrmiskiewicz piotrmiskiewicz self-assigned this Jul 8, 2024
@piotrmiskiewicz
Copy link
Member Author

piotrmiskiewicz commented Jul 8, 2024

Add more details about the failure, for example:

{
      "instanceID": "AC2441C3-67DA-432F-A211-38D4CB11A8E1",
      "runtimeID": "",
      "globalAccountID": "c43fa834-6c17-4e48-a436-1ddc5164f14c",
      "subscriptionGlobalAccountID": "",
      "subAccountID": "ee694042-9cc4-4675-9154-583ba30b0451",
      "region": "",
      "subAccountRegion": "cf-eu20-staging",
      "shootName": "c-33771c4",
      "serviceClassID": "47c9dcbf-ff30-448e-ab36-d3bad66ba281",
      "serviceClassName": "kymaruntime",
      "servicePlanID": "4deee563-e5ec-4731-b9b1-53b42d855f0c",
      "servicePlanName": "azure",
      "provider": "Azure",
      "status": {
        "createdAt": "2024-06-24T07:57:44.040102Z",
        "modifiedAt": "2024-06-24T14:59:11.763854Z",
        "state": "failed",
        "provisioning": {
          "state": "failed",
          "description": "Operation created",
          "createdAt": "2024-06-24T07:57:44.031495Z",
          "updatedAt": "2024-06-24T14:59:11.763854Z",
          "operationID": "ef5aa442-88ba-42dc-b68a-426c4e6d12c8",
          "finishedStages": [
            "start"
          ],
          "error": {
            "step": "check_kyma_runtime",
            "code": "ProvisioningTimeout",
            "message": "operation has reached the time limit",
            "team": "Framefrogs",
            "component": "provisioner"
          }
        }
      },
      "userID": "[email protected]",
      "avsInternalEvaluationID": 0
    }

Tasks, technical details:

OperationManager must be able to set the error details in the operation. The constructor should have additional parameter which indicates the step and component.
The KCP CLI must have an optional configuration which provides a mapping between the component and the team.
Check if the LastError can be used (package internal/errors).

In case of DeprovisionIncomplete - the error shows the problem

@piotrmiskiewicz
Copy link
Member Author

Add additional fields like:

betaEnabled, usedForProduction

@piotrmiskiewicz
Copy link
Member Author

piotrmiskiewicz commented Jul 8, 2024

listing kyma & runtime CRs in the KCP CLI

We don't see the reason to display Kyma resource from KCP environment. Runtime CR - done

@piotrmiskiewicz
Copy link
Member Author

piotrmiskiewicz commented Jul 8, 2024

Add new command to the KCP CLI, for example keb-status (or something else) which shows current, ongoing operations, for example:

> kcp rt-status -o json

"keb-status" could be an alias for all "in progress" statuses

or just

> kcp keb-status
INSTANCE ID                             GLOBAL ACCOUNT ID                      RUNTIME ID                              SERVICE PLAN NAME  SHOOT NAME    IN PROGRESS
AC2441C3-67DA-432F-A211-38D4CB11A8E1    c43fa834-6c17-4e48-a436-1ddc5164f14c   4deee563-e5ec-4731-b9b1-53b42d855f0c    azure              c-33771c4     provisioning
AB3D5BBB-67DA-432F-A211-38D4CB11A8E1    c43fa834-6c17-4e48-a436-1ddc5164f14c   a4bde500-e5ec-433a-b9b1-5abcd438g50c    aws                c-abc42cd     deprovisioning

The endpoint for the KEB status data can take data from the memory.

@PK85
Copy link

PK85 commented Jul 18, 2024

Waits till Maper is back from vacations

@PK85
Copy link

PK85 commented Sep 11, 2024

We need to meet with Maper and Benji, to discuss the scope

@piotrmiskiewicz
Copy link
Member Author

Next idea:
Store payloads sent by the Platform. All operations contains Provisioning Parameters and Updating Parameters which can be shown as an output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants