Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout for update operation #1230

Closed
jaroslaw-pieszka opened this issue Oct 1, 2024 · 2 comments
Closed

Timeout for update operation #1230

jaroslaw-pieszka opened this issue Oct 1, 2024 · 2 comments
Assignees

Comments

@jaroslaw-pieszka
Copy link
Contributor

jaroslaw-pieszka commented Oct 1, 2024

There are many timeouts defined for different steps and operations.
Some hard-wired in the code, some configurable.

For update operation we have timeout set to 40 minutes, which happens to be insufficient e.g. when MachineType is updated.

SRE suggests following approach as for update:

Introduce configuration for this timeout value in the KEB code and helm chart, with default having 120m (2 hours).
SRE would like to specify overrides for this configuration per each KCP environment.`

  • reconsider all timeouts involved during updating process (steps etc.)
  • take into consideration that some paths of execution are relatively short (administrators) and some take a lot of time (MachineType)
  • perhaps we need to prepare consistent approach for all timeouts used by KEB, create separate tickets - this ticket is focused on update operation.
@jaroslaw-pieszka jaroslaw-pieszka changed the title Timeouts for KEB operations Timeout for update operation Oct 1, 2024
@MarekMichali MarekMichali self-assigned this Oct 2, 2024
@MarekMichali
Copy link
Contributor

This is connected with #981

@MarekMichali
Copy link
Contributor

MarekMichali commented Oct 2, 2024

In update operation:

  • check step has hardcoded 40 min
  • check_runtime_resource has a configurable timeout through the APP_PROVISIONER_RUNTIME_RESOURCE_STEP_TIMEOUT key. The key is also used in provisioning operation

Other update steps have no timeout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants