Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read model configurations dynamically at runtime #197

Open
marcobebway opened this issue Oct 1, 2024 · 2 comments
Open

Read model configurations dynamically at runtime #197

marcobebway opened this issue Oct 1, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@marcobebway
Copy link
Collaborator

marcobebway commented Oct 1, 2024

Description

Currently we use the config.yml file to read the model configurations. We need to come up with another approach to read these configurations at runtime.

Reason(s)

  • Remove configuration hardcoding.
  • Support for loading dynamic configurations at runtime.
  • Support for the containerization of the Companion backend.
  • Support for the secret rotation at runtime (even if it is achieved by restarting the Companion deployment).

Acceptance Criteria
TBD

Results from research and team agreements

@marcobebway marcobebway changed the title [PoC] Read model configurations dynamically at runtime Read model configurations dynamically at runtime Oct 1, 2024
@marcobebway marcobebway added the enhancement New feature or request label Oct 1, 2024
@friedrichwilken
Copy link
Collaborator

Considerations

gen-ai-hub needs either
- A: env vars
- B: a json file, that is located at ~/.aicore/config.json, which can be changed via the env. var AICORE_HOME

Team agreement

  • Have one file for running the app that contains all the configurations.
  • Load config from file, set env vars for gen-ai-hub doc from config file via code.
  • When deploying to k8s, mount secret with all settings as config file.
  • Have the config in the json format for easy reading.
  • Watch changes in that file and restart app if accordingly.

@grischperl
Copy link
Collaborator

Desired final solution:

  • all variables moved from .env to config.json
  • default location of the config.json
  • if desire to change that location, do so by overriding location with an env-var / .env file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants