Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of inconsistent sidecar status in workspace #257

Open
8 tasks
triffer opened this issue Jul 20, 2023 · 4 comments
Open
8 tasks

Handling of inconsistent sidecar status in workspace #257

triffer opened this issue Jul 20, 2023 · 4 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@triffer
Copy link
Collaborator

triffer commented Jul 20, 2023

Description
The origin of this is the Operational Awarness workshop item #11.b. The assumption is, that if there is sidecar injection enabled or disabled in a namespace, all pods in the namespace should have a sidecar or no sidecar.
There is the scenario where the Injection-label is changed or removed while workloads were already deployed. This might result in a communication issue between workloads.
It should also be taken into account that the injection can be controlled by a label at pod level.

The proposed mitigation options were:

  • Changing/removing the injection-label is reverted by the Istio operator
  • Monitoring is established to detect whether the injection-label is consistently reflected in all deployed pods (=> all have a sidecar or all don't have a sidecar configured)

Reasons
The state of the sidecars in the namespace should be consistent with the configurations of the injection of the namespace. A customer might not be aware that changing this configuration requires a restart of the already deployed pods.

DoD:

  • provide documentation
  • release notes and What's New updates for Kyma customers
  • provide unit tests
  • provide integration tests
  • test on production-like environment
  • verify resource limits
  • followup issue
  • PR reviewer will verify code coverage and evaluate if it is acceptable

Attachments

@triffer triffer added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 20, 2023
@kyma-bot
Copy link
Contributor

This issue or PR has been automatically marked as stale due to the lack of recent activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Close this issue or PR with /close

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

@kyma-bot kyma-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 18, 2023
@kyma-bot
Copy link
Contributor

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

@kyma-bot
Copy link
Contributor

@kyma-bot: Closing this issue.

In response to this:

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@strekm strekm removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 23, 2023
@strekm strekm reopened this Nov 23, 2023
@kyma-bot
Copy link
Contributor

This issue or PR has been automatically marked as stale due to the lack of recent activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Close this issue or PR with /close

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

@kyma-bot kyma-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 22, 2024
@strekm strekm removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants