Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compass Manger correctly uses the passed context #42

Open
mvshao opened this issue Nov 13, 2023 · 1 comment
Open

Compass Manger correctly uses the passed context #42

mvshao opened this issue Nov 13, 2023 · 1 comment
Labels
area/application-connector Issues or PRs related to application connectivity

Comments

@mvshao
Copy link
Contributor

mvshao commented Nov 13, 2023

Description

Currently, the Compass Manager uses the context.TODO or context.Background instead of the context from the Reconcile loop. We need to change the logic to properly pass to the context function and use it.

@mvshao mvshao added the area/application-connector Issues or PRs related to application connectivity label Nov 13, 2023
@kyma-bot
Copy link
Contributor

This issue or PR has been automatically marked as stale due to the lack of recent activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Close this issue or PR with /close

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

@kyma-bot kyma-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 12, 2024
@mvshao mvshao removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/application-connector Issues or PRs related to application connectivity
Projects
None yet
Development

No branches or pull requests

2 participants