From 0019f73b47b056f83145dbeb07bc3d30130e22b3 Mon Sep 17 00:00:00 2001 From: Filip Strozik Date: Thu, 16 May 2024 10:59:10 +0200 Subject: [PATCH 1/4] draft --- README.md | 3 +++ cmd/main.go | 4 ++++ 2 files changed, 7 insertions(+) diff --git a/README.md b/README.md index 6d7b93432..f5617459c 100755 --- a/README.md +++ b/README.md @@ -2,6 +2,9 @@ # Kyma CLI +> [!WARNING] +> The kyme-cli in the version `2.x.x` is not anymore supported. Not all functionality will be moved to the kyma-cli in the `3.x.x` version. Read more [here](https://github.com/kyma-project/cli/issues/2051). + ## Overview Kyma CLI is a command line tool which supports [Kyma](https://github.com/kyma-project/kyma) developers. It provides a set of commands and flags you can use to: diff --git a/cmd/main.go b/cmd/main.go index bc552736c..ee5e5ae2f 100755 --- a/cmd/main.go +++ b/cmd/main.go @@ -1,6 +1,7 @@ package main import ( + "fmt" "os" "github.com/kyma-project/cli/cmd/kyma" @@ -8,6 +9,9 @@ import ( ) func main() { + // TODO: improve warning message + fmt.Println("WARNING: kyma command is deprecated and will be removed in the future") + command := kyma.NewCmd(cli.NewOptions()) err := command.Execute() From e8e048db4cc75de5eab15014d33b3efd769f5c8d Mon Sep 17 00:00:00 2001 From: Filip Strozik Date: Thu, 16 May 2024 13:26:52 +0200 Subject: [PATCH 2/4] update warning --- README.md | 3 ++- cmd/main.go | 3 +-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index f5617459c..e57e3de54 100755 --- a/README.md +++ b/README.md @@ -3,7 +3,8 @@ # Kyma CLI > [!WARNING] -> The kyme-cli in the version `2.x.x` is not anymore supported. Not all functionality will be moved to the kyma-cli in the `3.x.x` version. Read more [here](https://github.com/kyma-project/cli/issues/2051). +> All current commands are deprecated and new `v3` commands will be developed within `alpha` command group. +> Read more about the decision [here](https://github.com/kyma-project/community/issues/872). ## Overview diff --git a/cmd/main.go b/cmd/main.go index ee5e5ae2f..d6b1623d1 100755 --- a/cmd/main.go +++ b/cmd/main.go @@ -9,8 +9,7 @@ import ( ) func main() { - // TODO: improve warning message - fmt.Println("WARNING: kyma command is deprecated and will be removed in the future") + fmt.Print("WARNING: All current commands are deprecated and new v3 commands will be developed within alpha command group.\n\n") command := kyma.NewCmd(cli.NewOptions()) From bc5118c2c6e796abd09dc35eef146edf703bec28 Mon Sep 17 00:00:00 2001 From: Filip Strozik Date: Fri, 17 May 2024 11:57:57 +0200 Subject: [PATCH 3/4] Apply suggestions from code review Co-authored-by: Krzysztof Kwiatosz --- README.md | 2 +- cmd/main.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index e57e3de54..a6402c3c8 100755 --- a/README.md +++ b/README.md @@ -3,7 +3,7 @@ # Kyma CLI > [!WARNING] -> All current commands are deprecated and new `v3` commands will be developed within `alpha` command group. +> Version `v2` of kyma CLI is deprecated. This implies that all commands available within version `v2` are also deprecated. We started designing `v3` commands that will be first released within `alpha` command group. > Read more about the decision [here](https://github.com/kyma-project/community/issues/872). ## Overview diff --git a/cmd/main.go b/cmd/main.go index d6b1623d1..9269c5006 100755 --- a/cmd/main.go +++ b/cmd/main.go @@ -9,7 +9,7 @@ import ( ) func main() { - fmt.Print("WARNING: All current commands are deprecated and new v3 commands will be developed within alpha command group.\n\n") + fmt.Print("WARNING: All commands within v2 are deprecated. We are designing v3 of kyma CLI with a new set of commands that will be first released within alpha command group.\n\n") command := kyma.NewCmd(cli.NewOptions()) From f77d9e3a62178fa8da4dc623b1f9c3cd3472a794 Mon Sep 17 00:00:00 2001 From: Filip Strozik Date: Mon, 20 May 2024 08:08:08 +0200 Subject: [PATCH 4/4] Update README.md Co-authored-by: Grzegorz Karaluch --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index a6402c3c8..4040c77f8 100755 --- a/README.md +++ b/README.md @@ -3,7 +3,7 @@ # Kyma CLI > [!WARNING] -> Version `v2` of kyma CLI is deprecated. This implies that all commands available within version `v2` are also deprecated. We started designing `v3` commands that will be first released within `alpha` command group. +> The Kyma CLI version `v2`, with all commands available within this version, is deprecated. We've started designing the `v3` commands that will be first released within the `alpha` command group. > Read more about the decision [here](https://github.com/kyma-project/community/issues/872). ## Overview