Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant --module flag for manage/unmanage commands #2325

Open
kwiatekus opened this issue Jan 21, 2025 · 1 comment
Open

Remove redundant --module flag for manage/unmanage commands #2325

kwiatekus opened this issue Jan 21, 2025 · 1 comment
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.

Comments

@kwiatekus
Copy link
Contributor

Description

Commands to manage/unmanage module offers different way to specify target module than commands to add/delete module

kyma@v3 alpha module add keda --default-cr
vs
kyma@v3 alpha module manage --module keda
kyma@v3 alpha module unmanage --module keda

Remove the --module flag for manage/unmanage commands as it is redundant.
Make it:

`kyma@v3 alpha module manage keda`
`kyma@v3 alpha module unmanage keda`

Reasons

Consistency in this matter will be good for user experience

Attachments

@kwiatekus kwiatekus added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Jan 21, 2025
@kwiatekus
Copy link
Contributor Author

Please print out msg that confirms succesful operation:

"Module set to un-/managed"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
None yet
Development

No branches or pull requests

2 participants