From 5ea93f74d2a8fde0607ba7584126591083c95827 Mon Sep 17 00:00:00 2001
From: Filip Rudy <60617827+FilipRudy@users.noreply.github.com>
Date: Wed, 22 Jan 2025 10:01:59 +0100
Subject: [PATCH] remove redundant --module flag from manage & unmanage
commands (#2331)
---
internal/cmd/alpha/module/manage.go | 5 ++---
internal/cmd/alpha/module/unmanage.go | 4 ++--
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/internal/cmd/alpha/module/manage.go b/internal/cmd/alpha/module/manage.go
index e002e2e2c..405c7d6f8 100644
--- a/internal/cmd/alpha/module/manage.go
+++ b/internal/cmd/alpha/module/manage.go
@@ -23,18 +23,17 @@ func newManageCMD(kymaConfig *cmdcommon.KymaConfig) *cobra.Command {
Use: "manage <module>",
Short: "Manage module.",
Long: "Use this command to manage an existing module.",
-
+ Args: cobra.ExactArgs(1),
PreRun: func(_ *cobra.Command, args []string) {
clierror.Check(cfg.validate())
},
Run: func(cmd *cobra.Command, args []string) {
+ cfg.module = args[0]
clierror.Check(runManage(&cfg))
},
}
- cmd.Flags().StringVar(&cfg.module, "module", "", "Name of the module to manage")
cmd.Flags().StringVar(&cfg.policy, "policy", "CreateAndDelete", "Set custom resource policy. (Possible values: CreateAndDelete, Ignore)")
- _ = cmd.MarkFlagRequired("module")
return cmd
}
diff --git a/internal/cmd/alpha/module/unmanage.go b/internal/cmd/alpha/module/unmanage.go
index 8e749a204..c15708a32 100644
--- a/internal/cmd/alpha/module/unmanage.go
+++ b/internal/cmd/alpha/module/unmanage.go
@@ -21,13 +21,13 @@ func newUnmanageCMD(kymaConfig *cmdcommon.KymaConfig) *cobra.Command {
Use: "unmanage <module>",
Short: "Unmanage module.",
Long: "Use this command to unmanage an existing module.",
+ Args: cobra.ExactArgs(1),
Run: func(cmd *cobra.Command, args []string) {
+ cfg.module = args[0]
clierror.Check(runUnmanage(&cfg))
},
}
- cmd.Flags().StringVar(&cfg.module, "module", "", "Name of the module to unmanage")
- _ = cmd.MarkFlagRequired("module")
return cmd
}