Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete module with managed resources and operator resources #3345

Open
4 tasks
Tracked by #18450
pbochynski opened this issue Sep 16, 2024 · 1 comment
Open
4 tasks
Tracked by #18450

Delete module with managed resources and operator resources #3345

pbochynski opened this issue Sep 16, 2024 · 1 comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@pbochynski
Copy link
Contributor

pbochynski commented Sep 16, 2024

Description
Users should be aware of existing resources coming from the modules when they choose to delete one of them. If there is at least one resource user should be given a choice on how to proceed:

  1. cancel the deletion (nothing happens)
  2. delete all managed resources first and once the list is empty then delete the module

When the module is managed (entry exists in the default Kyma CR) the deletion should only remove that entry from Kyma CR. For not managed modules deletion should actively remove all module operator resources.

Reasons
Currently, the module deletion process can hang and users have to figure out how to unblock it themselves. The module operators wait until all dependent managed resources are deleted. Users have to find all of these resources and delete them one by one.
Another problem is that users are not aware of the consequences of the module deletion and can trigger deletion even if the module is in use (a lot of resources exist).

Acceptance Criteria

  • A list about affected resources is displayed after clicking the trash icon or Delete on the module
  • List in the warning modal contains information about the number of the existing affected resources (example: If user has 10 VirtualServices and wants to remove istio module, then in warning there should be info about this VS)
  • User can abort deleting by clicking Cancel
  • User can click force delete to remove all affected resources and then remove the module - Force delete kyma module #2613

Attachments
Epic: #3447
See the deletion scenario in this issue: kyma-project/kyma#18450

@pbochynski pbochynski changed the title Adjust module deletion to handle managed resources Delete module with managed resources and operator resources Sep 16, 2024
@mrCherry97 mrCherry97 added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 17, 2024
@mrCherry97
Copy link
Contributor

Will be planned after kyma-project/lifecycle-manager#1472
They will prepare the testing environment for us, and we will start working on this topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants