Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Warning for v2alpha1 APIRule that applies to all paths #1307

Open
6 tasks
triffer opened this issue Sep 16, 2024 · 0 comments
Open
6 tasks

UI Warning for v2alpha1 APIRule that applies to all paths #1307

triffer opened this issue Sep 16, 2024 · 0 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@triffer
Copy link
Collaborator

triffer commented Sep 16, 2024

Description
In the APIRule v2alpha1 API Proposal ADR it is mentioned in an example that there should be a warning if a rule applies to all paths.

path: /* # Should be warning user that it is not recommended, as it applies to all paths

If this is still valid we should add this warning to the UI or otherwise update the ADR.

DoD:

  • Provide unit and integration tests.
  • Provide documentation.
  • Verify if the solution works for both open-source Kyma and SAP BTP, Kyma runtime.
  • If you changed the resource limits, explain why it was needed.
  • Verify that your contributions don't decrease code coverage. If they do, explain why this is the case.
  • Add release notes.

Attachments
Follow up issue of #1282

@triffer triffer added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant