Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch processors implementation in v2alpha1 reconciliation #1147

Closed
3 tasks done
barchw opened this issue Jul 8, 2024 · 0 comments
Closed
3 tasks done

Switch processors implementation in v2alpha1 reconciliation #1147

barchw opened this issue Jul 8, 2024 · 0 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@barchw
Copy link
Collaborator

barchw commented Jul 8, 2024

Description
Api-gateway reconciliation loop will support separate loops for both v1beta1 and v2alpha1 after #1016. The follow up to this switch is to make sure that reconciliation processors used in the v2alpha1 loop will operate on the v2alpha1 APIRule version.

Reasons

  • The v2alpha1 reconciliation loop is using v1beta1 processors.
  • Support for new functionalities, like ext-auth handler, should use v2alpha1 APIRule as base for how to reconcile.

TODO:

PRs:

DoD:

  • Provide unit and integration tests.
    - [ ] Provide documentation.
    - [ ] Verify if the solution works for both open-source Kyma and SAP BTP, Kyma runtime.
    - [ ] If you changed the resource limits, explain why it was needed.
  • Verify that your contributions don't decrease code coverage. If they do, explain why this is the case.
    - [ ] Add release notes.

Attachments

@barchw barchw added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 8, 2024
@strekm strekm added this to the 2.6.0 milestone Jul 26, 2024
@triffer triffer self-assigned this Jul 30, 2024
@triffer triffer removed their assignment Aug 7, 2024
@videlov videlov self-assigned this Aug 7, 2024
@videlov videlov removed their assignment Aug 7, 2024
@strekm strekm closed this as completed Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants