Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Has this project been abandoned #41

Open
bonelifer opened this issue Mar 18, 2024 · 10 comments
Open

Has this project been abandoned #41

bonelifer opened this issue Mar 18, 2024 · 10 comments

Comments

@bonelifer
Copy link

@kylejohnson has this been abandoned?

@kylejohnson
Copy link
Owner

Hi - yes, for the most part, it has.

My original use-case for this project no longer exists, and additionally I no longer use Pandora.

@Doug-Wyman
Copy link

Doug-Wyman commented Mar 18, 2024

I might Grab your code and see if I can adapt it to a Pandora / MQTT program I have to work with Home Assistant. That is if you don't mind poachers. I should keep the browser part though. I've had to resort to it when HomeAssistant burps.
Doug Wyman 81 year old geezer

@kylejohnson
Copy link
Owner

kylejohnson commented Mar 19, 2024 via email

@Doug-Wyman
Copy link

Doug-Wyman commented Mar 19, 2024

I'm not sure if is frowned on to post this sort of reply...but my home assistant interface is a python app that watches for any change in the directory where Pianobar writes the current info. It sends that info to MQTT It also looks for a change in a in that folder and depending on the cammand sends the proper keystroke commands to the Patiobar/Pianobar cmd folder. I use the home assistant notify file which first writes a header when it begins the file the the HA service sends the command to that file.

@bonelifer
Copy link
Author

bonelifer commented Mar 20, 2024

@Doug-Wyman > I should keep the browser part though

That would be awesome. When you fork the repo could you link it here in this issue? I'd like to make a small change request about the stations menu and being able to set it to close even in desktop mode. It being open when not in use, is really annoying when trying to integrate it into myMPD interface via iframe.

@Doug-Wyman
Copy link

Doug-Wyman commented Mar 20, 2024

Changes to the browser layout would depend on my ability to follow the code. I have taught myself to code in everything from ASM on a Z80 many different BASICS and such but I never had formal or even peer training on how to layout code. Others are the same so one coder making good sense of the nuances of another's code can have problems. Wasn't until the later 4 or 5 years did I code on a three person team. Awesome genius. I uploaded it to my git desktop and will play alone for a while. Yes, I will definitely let you know when I have something usable. I sure would like to fit my MQTT interface inside Patiobar. Oh my first playing on a computer was 1962 at NSA/JSPC. Yes I know I flaunt that a lot but my life work has been fun.

@kylejohnson
Copy link
Owner

@Doug-Wyman > I should keep the browser part though

That would be awesome. When you fork the repo could you link it here in this issue? I'd like to make a small change request about the stations menu and being able to set it to close even in desktop mode. It being open when not in use, is really annoying when trying to integrate it into myMPD interface via iframe.

This thread has inspired me and I'm actually working on this right now myself.
The stations menu will close if the browser window is small enough - I need to change the breakpoint to make better sense of mobile vs. desktop.
Alternatively, I'm considering an alternative layout instead of the stations at the top - e.g. 2-column layout with stations on left, controls on right.

Thoughts?

@bonelifer
Copy link
Author

bonelifer commented Mar 20, 2024

I think both changes are good. Have a config file to switch between them. The two column would be good for people using only Patiobar by itself. I think in my case it would work better with the current layout but a collapsible menu. Possibly with a default breakpoint, but also an option to force it by setting it to 0.

update: the new layout maybe would be better like it is but with the stations at the bottom. Or have the Artwork on the left, with the controls on the right, stations below?

@kylejohnson
Copy link
Owner

@bonelifer Let's move that discussion over to #42

@Doug-Wyman
Copy link

@kylejohnson I love what I have read so far of your code. I will play here at home but I would much prefer if you could do the requests while I lurk in the background. If you are at all interested in my mqtt thing, I'll attach a copy in my reply. Python app on Debian/Raspbian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants