Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: nanoarrow refactor #45

Closed
wants to merge 9 commits into from
Closed

WIP: nanoarrow refactor #45

wants to merge 9 commits into from

Conversation

kylebarron
Copy link
Owner

@kylebarron kylebarron commented Aug 31, 2023 •
edited
Loading

Closes #41, closes #42

Change list:

  • Parse C FFI structs into plain JS objects. Then these intermediate objects can be stored on their own or converted to Arrow JS
  • Add writing support for writing the JS representation of these structs into Wasm memory directly, using a malloc function exported from wasm.

Todo:

  • Support converting Arrow JS objects into these structs.
  • Am I going to hit an issue with setting the release callback to the null pointer? It works with arrow2, but that might be implementation specific.

@kylebarron kylebarron marked this pull request as draft August 31, 2023 04:47
@kylebarron kylebarron mentioned this pull request Aug 31, 2023
Merged
@brettsaunders21
Copy link

Do you have plans to continue working on this feature and merge it eventually? Or was it just an experiment?

@kylebarron
Copy link
Owner Author

Which part? The nanoarrow refactor or writing to wasm memory? This PR is kinda intertwined among the two. The nanoarrow refactor is less likely to get merged; the main goal of that is to remove an Arrow JS dependency, but I don't think I have the development bandwidth to maintain a separate (even extremely minimal) Arrow implementation, so I'll probably shelve that. The writing part is useful even with Arrow JS and I'd like to have that merged, though I don't have a use case for it myself yet.

@kylebarron
Copy link
Owner Author

If there's any of this that you'd like to work on, feel free to discuss more and/or make a PR

@kylebarron kylebarron mentioned this pull request Dec 6, 2023
Closed
@kylebarron kylebarron mentioned this pull request Dec 16, 2023
Merged
1 task
@kylebarron
Copy link
Owner Author

I'm going to close this because I don't have the maintenance bandwidth to try and implement data structures for Arrow outside of Arrow JS, and I don't have a use case at this point where Arrow JS's bundle size is a deal-breaker.

@kylebarron kylebarron closed this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Writing to FFI structs Explore "nanoarrow-js"
2 participants
@kylebarron @brettsaunders21