We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example case: circle is a leaf:
circle
circle :: forall p i. Leaf I.SVGcircle p i circle props = element (ElemName "circle") props []
However, in the general case, I think in general it ought to be a node, for example when we need to store animation attributes in it.
I have been using the following alternative for that:
circleNode :: forall p i. Node I.SVGcircle p i circleNode = element (ElemName "circle")
There are more elements like this.
Should we turn such elements into Node, perhaps providing compatibility wrappers like the following?
Node
circle props = circleNode props []
The text was updated successfully, but these errors were encountered:
feat(kwohlfahrt#13): circleNode -> add
45b0180
fix(kwohlfahrt#13): circle should be a Node, not a Leaf
3f50d56
I think the correct way is to make it a Node but default
added 3f50d56
Sorry, something went wrong.
No branches or pull requests
Problem
Example case:
circle
is a leaf:However, in the general case, I think in general it ought to be a node, for example when we need to store animation attributes in it.
I have been using the following alternative for that:
There are more elements like this.
Question
Should we turn such elements into
Node
, perhaps providing compatibility wrappers like the following?circle props = circleNode props []
The text was updated successfully, but these errors were encountered: