Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify SHA1 on download #28

Open
kurin opened this issue Sep 16, 2017 · 0 comments
Open

verify SHA1 on download #28

kurin opened this issue Sep 16, 2017 · 0 comments

Comments

@kurin
Copy link
Owner

kurin commented Sep 16, 2017

This won't always be possible, but we should do it where we can.

B2 doesn't store the complete file hash on large object uploads. You can add it yourself... if you know it when you BEGIN the transfer. Even through there's an HTTP request you need to make to FINISH the large transfer, there's no facility there to say "okay here's the SHA1 of the whole thing I sent you," presumably because they don't want to have to calculate it themselves to verify it.

Also, it'd only work when users are downloading an entire object. Which I suspect is the majority use case, but which is kind of unsatisfying.

kurin added a commit that referenced this issue Jun 25, 2018
This checks the SHA1 hash on download and allows callers to set the SHA1
hash for large files on upload, addressing #51 and #28.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant