Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MeshTimeout with top-level MeshGateway is not allowed by validation #12764

Open
lobkovilya opened this issue Feb 5, 2025 · 2 comments
Open
Labels
kind/bug A bug triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lobkovilya
Copy link
Contributor

Description

Apply:

type: MeshTimeout
name: mt-1
mesh: default
spec:
  targetRef:
    kind: MeshGateway
    name: gateway-proxy
  from:
    - targetRef:
        kind: Mesh
      default:
        idleTimeout: 50s
        connectionTimeout: 51s
        http:
          requestTimeout: 52s
          streamIdleTimeout: 53s
          maxStreamDuration: 54s
          maxConnectionDuration: 55s

Result:

Error: YAML contains invalid resource: spec.from: must not be defined.

However, the following policy works

type: MeshTimeout
name: mt-1
mesh: default
spec:
  targetRef:
    kind: Mesh
    proxyTypes:
      - Gateway
  from:
    - targetRef:
        kind: Mesh
      default:
        idleTimeout: 50s
        connectionTimeout: 51s
        http:
          requestTimeout: 52s
          streamIdleTimeout: 53s
          maxStreamDuration: 54s
          maxConnectionDuration: 55s
@lobkovilya lobkovilya added kind/bug A bug triage/pending This issue will be looked at on the next triage meeting labels Feb 5, 2025
@lobkovilya
Copy link
Contributor Author

@michaelbeaumont do you know if it's expected and we need a better explanation in the error or it's a bug?

@lukidzi
Copy link
Contributor

lukidzi commented Feb 10, 2025

Triage: we should support MeshGateway and setting inbound timeouts for specific gateway

@lukidzi lukidzi added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

No branches or pull requests

2 participants