Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Envoy statPrefix should not use ip addresses #12733

Open
Automaat opened this issue Feb 3, 2025 · 2 comments
Open

Envoy statPrefix should not use ip addresses #12733

Automaat opened this issue Feb 3, 2025 · 2 comments
Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it
Milestone
2.11.x

Comments

@Automaat
Copy link
Contributor

Automaat commented Feb 3, 2025

Description

Using IP address in envoy config statPrefix field can cause issues or generate unnecessary changes in metrics. This is also problematic for our e2e tests that test envoy config.

We could use inbound name instead.
@Automaat Automaat added kind/feature New feature triage/pending This issue will be looked at on the next triage meeting labels Feb 3, 2025
@Automaat
Copy link
Contributor Author

Automaat commented Feb 3, 2025

ATM for e2e tests fix is here: #12732 but we need to find better naming for this prefixes

@bartsmykla
Copy link
Contributor

Triage: this is a valid issue and we should create an MADR with the naming of all components in envoy

@bartsmykla bartsmykla added triage/accepted The issue was reviewed and is complete enough to start working on it kind/improvement Improvement on an existing feature and removed triage/pending This issue will be looked at on the next triage meeting kind/feature New feature labels Feb 3, 2025
@lahabana lahabana added this to the 2.11.x milestone Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
2.11.x
Development

No branches or pull requests
3 participants
@lahabana @Automaat @bartsmykla